fix: explorer content leaking into viewport on mobile#2352
Open
prasanth-ntu wants to merge 1 commit intojackyzha0:v4from
Open
fix: explorer content leaking into viewport on mobile#2352prasanth-ntu wants to merge 1 commit intojackyzha0:v4from
prasanth-ntu wants to merge 1 commit intojackyzha0:v4from
Conversation
On mobile, the collapsed explorer uses `visibility: hidden` + `transform: translateX(-100vw)` to hide its content panel. However, `.folder-outer.open` inside it sets `visibility: visible`, which per CSS spec overrides the parent's hidden visibility. Combined with the explorer-content being positioned relative to `.sidebar.left` (which has padding from the viewport edge), the translateX(-100vw) doesn't fully move the content off-screen, causing a few pixels of explorer links to bleed into the visible viewport. Fix: override `.folder-outer.open` visibility to hidden when the explorer is in its collapsed state on mobile.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On mobile, a few pixels of explorer navigation links bleed into the visible viewport when the explorer is collapsed, appearing as floating text on the left edge of the screen.
Root cause: The collapsed explorer uses
visibility: hidden+transform: translateX(-100vw)to hide its content panel. However:.folder-outer.openinside it setsvisibility: visible, which per CSS spec overrides the parent'svisibility: hidden.explorer-contentis absolutely positioned relative to.sidebar.left(which has padding from the viewport edge), sotranslateX(-100vw)doesn't fully move the content off-screenThis causes visible explorer links to leak through the ~16px gap.
Fix: Override
.folder-outer.openvisibility tohiddenwhen the explorer is in its collapsed state on mobile.Screenshots
Before (floating text circled on left edge):
Test plan