Use friendly monitor name on Windows.#52
Open
wangfu91 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for friendly monitor names on Windows to improve the user interface display of monitor information. It upgrades the brightness crate from version 0.5.0 to 0.8.0 and updates the monitor property handling to include and display the more user-friendly monitor names.
Key changes:
- Added
FriendlyDeviceNameenum variant and corresponding struct field for Windows monitor properties - Updated the UI to display friendly device names instead of technical device names
- Upgraded the
brightnesscrate dependency for improved compatibility
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/gui/status.rs | Updates UI to display friendly device name instead of technical device name |
| src/config.rs | Adds FriendlyDeviceName enum variant with display name "Friendly Name" |
| src/apply.rs | Adds friendly_device_name field to MonitorProperties and populates it from device API |
| Cargo.toml | Upgrades brightness crate from 0.5.0 to 0.8.0 and reformats win32-utils dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the handling of monitor properties, particularly for Windows, and upgrades a key dependency. The main changes include adding support for a "friendly device name" for monitors, updating the codebase to use this new property in both logic and UI, and bumping the
brightnesscrate version for improved compatibility and features.Before:

After: