Skip to content

Use friendly monitor name on Windows.#52

Open
wangfu91 wants to merge 1 commit into
jacob-pro:masterfrom
wangfu91:win-friendly-display-name
Open

Use friendly monitor name on Windows.#52
wangfu91 wants to merge 1 commit into
jacob-pro:masterfrom
wangfu91:win-friendly-display-name

Conversation

@wangfu91

@wangfu91 wangfu91 commented Sep 5, 2025

Copy link
Copy Markdown

This pull request updates the handling of monitor properties, particularly for Windows, and upgrades a key dependency. The main changes include adding support for a "friendly device name" for monitors, updating the codebase to use this new property in both logic and UI, and bumping the brightness crate version for improved compatibility and features.

Before:
sattus-before

After:

sattus-after

Copilot AI review requested due to automatic review settings September 5, 2025 13:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for friendly monitor names on Windows to improve the user interface display of monitor information. It upgrades the brightness crate from version 0.5.0 to 0.8.0 and updates the monitor property handling to include and display the more user-friendly monitor names.

Key changes:

  • Added FriendlyDeviceName enum variant and corresponding struct field for Windows monitor properties
  • Updated the UI to display friendly device names instead of technical device names
  • Upgraded the brightness crate dependency for improved compatibility

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
src/gui/status.rs Updates UI to display friendly device name instead of technical device name
src/config.rs Adds FriendlyDeviceName enum variant with display name "Friendly Name"
src/apply.rs Adds friendly_device_name field to MonitorProperties and populates it from device API
Cargo.toml Upgrades brightness crate from 0.5.0 to 0.8.0 and reformats win32-utils dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants