Fix environment-dependent path and locale in split comparison tests#201
Merged
Conversation
- Normalize stack-trace source paths anchoring on the TestAssets* project folder instead of stripping a dynamically computed / CI-hardcoded base dir, so the expected/actual comparison is reproducible in any checkout and OS. - Force English UI culture (DOTNET_CLI_UI_LANGUAGE=en) when generating the trx assets in run-test.bat and CI, so localized framework messages (e.g. MSTest asserts) match the expected files independently of the OS language. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The split comparison tests (
TestDotnetTestSplit) were only reproducible in the exact GitHub Actions environment:ReadComparablestripped a base directory computed dynamically fromDirectory.GetCurrentDirectory()(curDir.Length - 4), while theexpected/fixtures had the CI absolute path (/home/runner/work/dotnet-test-split/dotnet-test-split/) baked into their stack traces. These only matched inside that CI path, so the tests failed on any local checkout.expected/fixtures.🤖 Generated with Claude Code