Added the ability to inline JS and CSS#491
Open
simultech wants to merge 1 commit intojazzband:masterfrom
Open
Conversation
Adds the ability to do inline JS/CSS with pipeline by adding ‘inline’
to the template tag, aka:
{% javascript 'head_js' 'inline' %}
|
This feature would also be useful for me. |
Author
|
Anyone reading this we were able to monkey-patch it in to live by duplicating the template-tags in your own app, and overriding the django-pipeline tags to support 3 arguments (and then return the output into the template) |
Contributor
|
This seems reasonable, but a cleaner solution would be to have separate templatetags instead of trying to parse a variable number of arguments. |
|
Inlining CSS is also great for HTML emails! I'd really would like to get support for that in this module. Is there anything I can do to help get this module in better shape? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to do inline JS/CSS with pipeline by adding ‘inline’
to the template tag, aka:
{% javascript 'head_js' 'inline' %}
This pull request is for the aim of opening the discussion around what needs to be done to enable inline embedding of Javascript and CSS directly into the page. This is useful when optimizing network requests for styles/scripts only relevant to a single page.