Extract and store v-key values from received messages#35
Closed
fonic wants to merge 2 commits intojech:masterfrom
fonic:krpc-v-key
Closed
Extract and store v-key values from received messages#35fonic wants to merge 2 commits intojech:masterfrom fonic:krpc-v-key
fonic wants to merge 2 commits intojech:masterfrom
fonic:krpc-v-key
Conversation
Extend debug message logging / debug output: - add support for message types (debug, info, warning, error) - introduce logging macros to easily log messages (debugf, infof, warnf, errorf) - log messages to user-defined callback instead of file so that application may be decide how to handle debug output - add string conversion functions that may be used in printf-style function calls (address family, IP protocol version, bucket/node ID, socket address, etc.) - add DHT_LOG_ defines to control certain features - add function to retrieve statistics (buckets, good nodes, dubious nodes, total nodes) - modify dump_bucket() and dht_dump_tables() to output tables - migrate all debugf calls to make use of the new capabilities - add additional debug output - modify dht-example to make use of the new capabilities
Additions/changes: - modify parse_message() to extract v-key value from received messages and store in message struct - modify new_node() to include v-key value in parameter list and to store v-key value in node struct for both instant arrival (new node is added after receiving pong message) and late arrival (new node is added after 'Nodes found', but pinged later) - update all calls to new_node() to account for new parameter list - modify dump_buckets() to include v-key values
Owner
|
Sorry, the logging infrastructure won't go in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the message parser to extract and store v-key values (client identifier + version info). Contents are useful e.g. to help analyze incompatibilities with certain clients, e.g. when receiving unparseable message one can check if this is related to a certain client software.
Additions/changes:
parse_message()to extract v-key value from received messages and store in message structnew_node()to include v-key value in parameter list and to store v-key value in node struct for both instant arrival (new node is added after receiving pong message) and late arrival (new node is added after 'Nodes found', but pinged later)new_node()to account for new parameter listdump_buckets()to include v-key valuesNOTE:
Screenshot:
