Add a complete comment system for minima#702
Open
YURLAK wants to merge 7 commits intojekyll:masterfrom
Open
Conversation
Member
|
Hello @YURLAK, Regarding your pull request, I love the idea but would like to leave some feedback nevertheless:
|
Author
|
Hello,@ashmaroli.Thanks for your feedback!According to your feedback,I made some changes.Readability does matter,I updated |
louisroyer
suggested changes
Jan 3, 2023
| ### Enabling comments (via Disqus,Utterances,Giscus) | ||
|
|
||
| Optionally, if you have a Disqus account, you can tell Jekyll to use it to show a comments section below each post. | ||
| If you want to add comment system for your site,add the following code to the `README.md` file.If not,skip this part. |
There was a problem hiding this comment.
Suggested change
| If you want to add comment system for your site,add the following code to the `README.md` file.If not,skip this part. | |
| If you want to add comment system for your site, add the following code to the `README.md` file. If not, skip this part. |
| label: "Comments" | ||
| theme: "your_theme" | ||
|
|
||
| # You must install giscus github app before use.(https://github.com/apps/giscus) |
There was a problem hiding this comment.
Suggested change
| # You must install giscus github app before use.(https://github.com/apps/giscus) | |
| # You must install giscus github app before use (https://github.com/apps/giscus). |
Member
|
@YURLAK I thought about this bit more. Continuing from previous feedback:
So, our {% if jekyll.environment == "production" %}
{% unless page.comments == "disabled" %}
{% assign comments_provider == site.minima.comments_provider %}
{% if comments_provider %}
{% capture provider_filepath %}comments/{{ comments_provider }}.html{% endcapture %}
{% include {{ provider_filepath }} %}
{% endif %}
{% endunless %}
{% endif %}Then, we document what users need to do, in our README along with the note that build will fail if user does not provide associated include file. |
Co-authored-by: Louis Royer <55180044+louisroyer@users.noreply.github.com>
Co-authored-by: Louis Royer <55180044+louisroyer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, developers!👋This is my first PR.
Problem.
Minima has less comment system.And disqus has been deprecated.
How to realize it?
I changed three places.
/includes/comments.html,Delete/includes/disqus_comments.html._config.yml._layouts/post.html.At last
After my changes.Now Giscus,Utterance and Disqus are available now.
I tested it successfully on my blog.
And that's all.Thanks😀