Add optional fa_icon_pack property to social_links to allow more Font Awesome icons packs beyond brands#844
Add optional fa_icon_pack property to social_links to allow more Font Awesome icons packs beyond brands#844pfirpfel wants to merge 1 commit intojekyll:masterfrom
Conversation
|
Hello again, @pfirpfel The one viable solution I see here is to force everyone to set the entire necessary Font Awesome icon classlist: minima:
social_links:
- title: Jekyll repository at GitHub
icon: "fab fa-github"
url: "https://github.com/jekyll/jekyll"
- title: Email Jekyll
icon: "far fa-envelope"
url: "mailto:jekyll@example.com"Note how one can now opt to use N.B. You need not rebase your branch if you choose to make changes. We use squash merges here. |
|
Any thoughts on my suggestion above, @pfirpfel? |
Summary
Extends functionality introduced in #839. Proposal for my issue raised here: #843
Interface changes
Adds an optional property to the config keys under minima:social_links. Will not break existing configurations.
Motivation
Allow users to use icons from Font Awesome beyond the brands icon pack in their social links.