fix: cast day_number to int when loading month content - #899
Closed
saschabuehrle wants to merge 1 commit into
Closed
fix: cast day_number to int when loading month content#899saschabuehrle wants to merge 1 commit into
saschabuehrle wants to merge 1 commit into
Conversation
Owner
|
Merged #898 instead. Thanks anyway! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #897
YAML can deserialize dictionary keys as strings depending on the document format. When that happens,
datetime.date()inDay.__init__()crashes withTypeError: 'str' object cannot be interpreted as an integerbecause the day number is still a string.Casting to
int()inMonth.__init__()before constructing theDayfixes the crash.-- saschabuehrle