Fix dropout parameter in LeakyParallel - #405
Open
igorperic17 wants to merge 1 commit into
Open
Conversation
- Fix dropout not working in LeakyParallel due to nn.RNN only applying dropout to intermediate layers (not the last layer) - Since LeakyParallel uses num_layers=1, manually apply dropout to RNN output instead of passing it to nn.RNN - Add comprehensive test suite for LeakyParallel dropout functionality - Update docstring to clarify dropout behavior Fixes GitHub issue where dropout parameter had no effect even when set to 1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GitHub issue where dropout parameter had no effect even when set to 1.0 #403