Open
Conversation
Contributor
|
I'm wary of silently ignoring |
…dling of NaN values in PolarPlots
Author
|
I've updated the PR so that there is now a mutable property called Additionally if
|
Contributor
|
For reference, this branch can be tested in a local clone, as shown here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proposal fix for issue #409
respects NaN values and skips them
Open for discussion: What should happen with "connect first and last point" feature? Now it just connects the first and last non-NaN points (which could be misleading). Please just open a new issue for that and assign it to me if you would want to have this changed.