Fix Gradle automated dependency updates for multi-module projects#1276
Open
orto17 wants to merge 1 commit intojfrog:v3_erfrom
Open
Fix Gradle automated dependency updates for multi-module projects#1276orto17 wants to merge 1 commit intojfrog:v3_erfrom
orto17 wants to merge 1 commit intojfrog:v3_erfrom
Conversation
Use Gradle-specific recursive descriptor collection with directory skips (.gradle, build, node_modules, etc.) instead of the generic CommonPackageUpdater walk, so submodule build.gradle files are found reliably for automated fixes. Tests: TestGetAllGradleDescriptorFilesFullPaths; Gradle fix test uses getAllGradleDescriptorFilesFullPaths. Made-with: Cursor
orto17
added
the
safe to test
github-actions
Bot
removed
the
safe to test
Collaborator
eranturgeman
left a comment
eranturgeman
left a comment
There was a problem hiding this comment.
see my review in #1275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frogbot’s Gradle fix path only considered build.gradle / build.gradle.kts files in the repository root. In multi-module Gradle layouts, direct dependencies are often declared only in subproject build files, so fixes failed with errors such as “impacted package … was not found or could not be fixed in all descriptor files” even when those coordinates appeared in a submodule.
This change adds a recursive walk that collects Gradle descriptors across the tree, while skipping common non-source directories (for example .git, .gradle, build, node_modules, IDE folders).