Open
Conversation
Replaces the undocumented --json bool flag with --format (accepted: json,
table; default: table). The default remains CSV (table) to match existing
behaviour; --format json emits the full {"workers":[...]} JSON response.
The --json flag is removed; scripts must migrate to --format json.
Supports json (default) and table output formats for the execute command, consistent with the worker list command.
Accepted formats: json (default, backward-compatible) and table. The table output is CSV with columns: start, end, testRun, result, logs. No --json flag existed previously, so no removal was needed.
Accepted formats: json (default, backward-compatible) and table. Table output renders the worker response as CSV key-value rows. No --json flag was removed as the command did not have one.
Accepts json and table formats; default is table (preserves the existing comma-separated plain-text output for backward compatibility). JSON output returns the full ActionMetadata array. Added PrintJSONValue helper to commands/common/cmd_io.go.
Pattern B (HTTP call, body discarded): --format json emits a synthetic
{"status_code": 200, "message": "OK"} JSON object; --format <other>
returns an error; omitting --format preserves the existing log-only
behaviour for backward compatibility. No --json flag was removed.
Pattern B: only json is supported (no tabular data). When --format json
is passed, prints {"status_code": 200, "message": "OK"}. Unsupported
formats return an error. When no --format flag is given, behaviour is
unchanged (log lines only, no JSON output).
ed0e53b to
110d808
Compare
Contributor
Unit Tests Results257 tests +26 257 ✅ +26 1m 20s ⏱️ -1s Results for commit 39d443e. ± Comparison against base commit be568d9. This pull request removes 1 and adds 27 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
ehl-jf
commented
Apr 24, 2026
| github.com/jfrog/go-mockhttp v0.3.1 | ||
| github.com/jfrog/jfrog-cli-core/v2 v2.60.0 | ||
| github.com/jfrog/jfrog-client-go v1.55.0 | ||
| github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260424064607-168e6cd94fc8 |
Collaborator
Author
There was a problem hiding this comment.
This is JGC-471-format-flag branch.
Should be replace with master prior to merge, once jfrog-cli-core will be merged
110d808 to
39d443e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainbranch.go vet ./....go fmt ./....