Skip to content

Conversation

@attiasas
Copy link
Contributor

@attiasas attiasas commented Jan 19, 2026

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

We calculated the direct components as the direct parent of the impacted component.
This PR fixes the issue and caclulate the actual direct components in the SBOM for the given impacted component.

In addition:

  1. adding id attribute to simple-json ComponentRow struct with the component BomRef/XrayComponentId
  2. adding location to impact paths as well, if provided.

…ponent and add ID to simplejson.ComponentRow
@attiasas attiasas added the ignore for release Automatically generated release notes label Jan 19, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 19, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 19, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 19, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 19, 2026
@attiasas attiasas changed the title Static-SCA: Fix direct component in Sbom calculation for impacted com… Static-SCA: Fix direct component in Sbom calculation for impacted component Jan 19, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 19, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 19, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 19, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 19, 2026
Copy link
Contributor

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! see my notes and please add in the pr detains what is the addition of the property

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 20, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 20, 2026
@github-actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants