feat: v2 - #422
Closed
aklkv wants to merge 0 commit into
Closed
Conversation
aklkv
force-pushed
the
feat/v2
branch
3 times, most recently
from
October 23, 2024 08:02
d8b0268 to
fd70fa4
Compare
aklkv
force-pushed
the
feat/v2
branch
7 times, most recently
from
January 27, 2025 08:37
9c56234 to
cbea50f
Compare
aklkv
marked this pull request as ready for review
January 27, 2025 08:41
aklkv
force-pushed
the
feat/v2
branch
13 times, most recently
from
July 3, 2025 02:07
baec30f to
8441481
Compare
aklkv
force-pushed
the
feat/v2
branch
2 times, most recently
from
July 6, 2025 10:44
7db2f9c to
cd3a2bf
Compare
aklkv
force-pushed
the
feat/v2
branch
2 times, most recently
from
July 13, 2025 00:43
5656257 to
ec1399d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the addon to a new v2 format by removing legacy tests, introducing a TypeScript-based test-app, and adding a Kolay-powered docs-app.
- Remove all classic-format tests and test helpers
- Add a new
test-appwith TypeScript, Glint support, and modern test-loader - Introduce a
docs-apppowered by Kolay with basic rendering and route tests
Reviewed Changes
Copilot reviewed 152 out of 182 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test-helper.js | Deleted legacy test setup |
| test-app/tests/helpers/index.ts | Added new TS test helper and wrappers around ember-qunit |
| docs-app/vite.config.mjs | Configured Vite build with Ember and Kolay plugins |
Comments suppressed due to low confidence (2)
docs-app/config/environment.js:44
- [nitpick] The production environment overrides for
rootURLandlocationTypeare commented out. If you intend to deploy this app under a subdirectory (e.g., GitHub Pages), re-enable and updateENV.rootURLandENV.locationTypeaccordingly to avoid routing issues in production.
// here you can enable a production-specific feature
test-app/tests/helpers/index.ts:13
- The
NestedHookstype is not imported in this file, which will cause a TypeScript error. Please add an import for NestedHooks from 'ember-qunit' or 'qunit' (e.g.,import type { NestedHooks } from 'ember-qunit';).
function setupApplicationTest(hooks: NestedHooks, options?: SetupTestOptions) {
Contributor
Author
|
@jkusa any update, can I do anything to get this merged and released? |
jkusa
requested changes
Aug 1, 2025
|
|
||
| function clipboard(element, params, hash) { | ||
| export interface ClipboardModifierSignature { | ||
| Args: { |
Owner
There was a problem hiding this comment.
Can we update this based on the definition here: https://github.com/jkusa/ember-cli-clipboard/blob/73790700372a540bed1213a4bcf078edcc5164d9/index.d.ts
Contributor
Author
There was a problem hiding this comment.
I tried but ClipboardJS types are bit wrong
| element.setAttribute('data-clipboard-action', action); | ||
|
|
||
| if (!isBlank(text)) { | ||
| if (!isBlank(text) && text) { |
Owner
There was a problem hiding this comment.
what case does the && text catch that isBlank doesn't?
Contributor
Author
There was a problem hiding this comment.
I do not think that isBlack handles or exposes correct types to handle undefined
aklkv
force-pushed
the
feat/v2
branch
2 times, most recently
from
August 1, 2025 03:48
cefbc13 to
76ecc2e
Compare
aklkv
force-pushed
the
feat/v2
branch
7 times, most recently
from
August 1, 2025 05:02
1a3284b to
9a95d52
Compare
Contributor
Author
|
@jkusa could we possibly merge this? |
Contributor
Author
|
@jkusa 👋🏻 any chance we can move this along? |
aklkv
force-pushed
the
feat/v2
branch
2 times, most recently
from
May 29, 2026 23:50
0ae6df7 to
eecf79b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #421
What is happening here:
test-appin classic format for two things: fastboot tests and test-helpers (this is interesting one and I think we should deprecate is since helpers use private methods that are accessible in the vite https://discord.com/channels/480462759797063690/483601670685720591/1389530629921574973)Follow up items: