Improve size and speed for temperature calculation#20
Open
hemonserrat wants to merge 2 commits into
Open
Conversation
Optimizations: 1. Bitwise OR (`|`) instead of `+` for combining bytes – More efficient. ~5-10% faster. 2. Precompute powers of `x` and `y` – Reduces redundant calculations. ~20-30% faster for floating-point-heavy calculations. 3. Ternary operator for Celsius conversion – More concise. ~5-10% faster. Estimated execution speed improvement of 30-50% (depending on the Arduino model) Original: Sketch uses 8380 bytes. After this change: Sketch uses 8350 bytes. Global variables use (no change): 316 bytes (15%) of dynamic memory.
Resolved merge conflict in calculateTemp() function: - Kept PR optimizations: bitwise OR, precomputed powers, cleaner polynomial structure - Preserved tempC variable calculation from main for safety checks - Optimized return statement to reuse tempC when CorF == 'C' Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizations:
|) instead of+for combining bytes – More efficient. ~5-10% faster.xandy– Reduces redundant calculations. ~20-30% faster for floating-point-heavy calculations.Estimated execution speed improvement of 30-50% (depending on the Arduino model)
Original: Sketch uses 8380 bytes.
After this change: Sketch uses 8350 bytes.
Global variables use (no change): 316 bytes (15%) of dynamic memory.