fix: await virtual display initialization#5554
Open
matus01 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Linux launch failure where the virtual display value is passed as a Promise instead of the resolved display string.
Problem
When creating a browser tab on Linux, Camoufox failed to launch with:
The
/tabsrequest then returned500.The log also showed the virtual display value as an object:
Cause
VirtualDisplay.get()returns a Promise, but the result was used withoutawait:As a result,
vdDisplaycontained a Promise object instead of the actual Xvfb display string.Fix
Await the virtual display initialization:
Testing
Tested locally on Linux with
@askjo/camofox-browser 1.11.2.Before the change, browser launch failed with:
After the change, the server was able to create browser tabs successfully.