fix: chart jumping and wobbling on window.devicePixelRatio !== 1#136
Draft
WofWca wants to merge 6 commits intojoewalnes:masterfrom
Draft
fix: chart jumping and wobbling on window.devicePixelRatio !== 1#136WofWca wants to merge 6 commits intojoewalnes:masterfrom
window.devicePixelRatio !== 1#136WofWca wants to merge 6 commits intojoewalnes:masterfrom
Conversation
The issue is noticeable at `millisPerPixel` being between ~ 0.5 & 2.0 the size of `requestAnimationFrame` period. Canvas image update period would be inconsistent - some would last longer, some less, some would get skipped altogether.
This reverts f1a0a88
WofWca
force-pushed
the
fix-jumpiness-dpr-not-1
branch
from
4ff71d9 to
b6a6b0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151.
TODO:
pixelSnapworks correctly forlineWidth % (2 * coordinatesPerPixel) === 0