Add linked administrative regions#2390
Open
ylub wants to merge 2 commits into
Open
Conversation
Author
|
Hello - just wondering if there's any updates on this PR Thanks! |
Collaborator
|
Could you expand on how this PR adds less weight than #2383 ? I really think we need to come up with some kind of compressed format if we want this to be sustainable. |
Author
|
I was under the impression that these smaller changes were not as heavy as that huge 3000 line one from #2383. Perhaps the admin regions that already exist in each country's provider could be used as aliases and it would be a matter of adding what is missing as well as the commands that link them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
This PR adds linked administrative region methods for the following European locales:
'de_AT''cz_CZ''de_DE''fr_FR''it_IT''pl_PL'sk_SK''sl_SI'This is somewhat related to #2383, but adds considerably less weight to
fakerWhat was missing
Several of these locales already included first-level administrative regions, while some also included second-level administrative regions. However, there was no consistent way to generate linked administrative subdivisions where a generated second-level region belongs to a specific first-level region.
How this addresses it
This PR adds methods for working with linked administrative regions:
fake.admin1()fake.admin2()fake.admin2_from_admin1(admin1)fake.admin2_with_admin1()fake.admin2_w_admin1(admin1)Administrative region data was sourced from Statoids, Wikipedia's ISO 3166-2 references and administrative subdivision pages, and official government sources where available.
AI Assistance Disclosure (REQUIRED)
I used ChatGPT for help in finding sources for the information, as well as to fine tune the code and for the fork/pull request.
Checklist