feat: support TagValue and TagAttribute for deserialization#17
Open
aerfus wants to merge 2 commits into
Open
Conversation
3396e15 to
76d4b18
Compare
Author
|
@jonas-grgt could you please review? |
Owner
|
@aerfus apologies for the delayed review. This is amazing work and I have absolutely nothing to comment on beside one thing, could you add this new capability to the README so it is clearly documented? After that it is ready to be merged! |
Author
|
Hello @jonas-grgt , I've updated the README.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce new annotations
Those annotations serve as self reference for XML tag <-> Java class
Refs #16