[5.4] Add missing SVG to images extensions#47885
Closed
artur-stepien wants to merge 1 commit into
Closed
Conversation
Contributor
|
This was by purpose. https://docs.joomla.org/J4.x:Media:_Uploading_SVG_files |
Contributor
|
beat me to it @chmst |
Contributor
Author
|
Need to check the reason why my SVG wasn't detected as SVG. As I can see in 5.4-dev branch the mod_banners should checks for image type in two methods. The one I changed and checking mime type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds SVG to image extensions list used in
\Joomla\CMS\Helper\MediaHelper::isImage. Without this you can select SVG as your banner image but it will not show up inmod_bannersSummary of Changes
Treat SVG files as images.
Testing Instructions
mod_bannersmodule to your website and make it display your bannersActual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed