Skip to content

[6.2] Remove obsolete variable definition#47912

Merged
MacJoom merged 2 commits into
joomla:6.2-devfrom
HLeithner:6.2/remove/deprecated-variable
Jun 14, 2026
Merged

[6.2] Remove obsolete variable definition#47912
MacJoom merged 2 commits into
joomla:6.2-devfrom
HLeithner:6.2/remove/deprecated-variable

Conversation

@HLeithner

Copy link
Copy Markdown
Member

Cleanup

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Remove the $allowLegacyListeners definition in the Plugins since they will never checked
in the relevant function because of the implementation of the SubscriberInterface

Note: The deprecation notice for 7.0 is for the CMSPlugin class not for the subclass which might implement them.

Testing Instructions

Code Review

Actual result BEFORE applying this Pull Request

2FA Works

Expected result AFTER applying this Pull Request

2FA Works

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@HLeithner HLeithner force-pushed the 6.2/remove/deprecated-variable branch from af6aae0 to 58a3920 Compare June 7, 2026 10:02
@joomdonation

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 58a3920

Code review + real tests with Fixed Code and Authentication Code by Email plugins.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47912.

@laoneo

laoneo commented Jun 10, 2026

Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 58a3920


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47912.

@alikon

alikon commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47912.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 10, 2026
@MacJoom MacJoom added this to the Joomla! 6.2.0 milestone Jun 14, 2026
@MacJoom MacJoom merged commit 7523d5f into joomla:6.2-dev Jun 14, 2026
57 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 14, 2026
@MacJoom

MacJoom commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants