Skip to content

[6.2] Fixes code style issues in Github Workflow#47914

Open
laoneo wants to merge 6 commits into
joomla:6.2-devfrom
Digital-Peak:fix/code-style
Open

[6.2] Fixes code style issues in Github Workflow#47914
laoneo wants to merge 6 commits into
joomla:6.2-devfrom
Digital-Peak:fix/code-style

Conversation

@laoneo

@laoneo laoneo commented Jun 7, 2026

Copy link
Copy Markdown
Member
  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Fixes code style issues during the Github workflow. Only issue is that no new workflow is started and the test results do not appear here. this comes from a security issue where github doesn't trigger new workflows when the bot changes something in the code base (according to Claude).

Additionally it updates all images to PHP 8.5.

Remark

In Joomla 7.0 we have to remove the phpcs dependency and code style xml file.

Testing Instructions

Check if my extra code style error is fixed in this pr and a new commit is done by the bot.

Actual result BEFORE applying this Pull Request

No code style fix and a failed workflow.

Expected result AFTER applying this Pull Request

Fix is commited to the pr and the other checks are running through.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67

Copy link
Copy Markdown
Member

There is another PR for the same purpose for the 5.4-dev branch: #46874

@laoneo

laoneo commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

I saw that and was a bit hesitant to add an action for this which I never used before.

@Hackwar

Hackwar commented Jun 10, 2026

Copy link
Copy Markdown
Member

Does it also fix the files with the --diff argument?

@richard67

Copy link
Copy Markdown
Member

@laoneo Other question is why is this PR made for the 6.2-dev branch? Any new feature policy does not apply to our CI checks / GitHub actions, and to me it makes no sense to have it different in 5.4-dev/6.1-dev and 6.2-dev/7.0-dev.

@laoneo

laoneo commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

Closing as we di it on 5.4 in #47936.

@laoneo laoneo closed this Jun 11, 2026
@laoneo laoneo deleted the fix/code-style branch June 11, 2026 07:52
@laoneo laoneo restored the fix/code-style branch June 15, 2026 14:23
@laoneo laoneo reopened this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants