fix: BinaryCalculator::product() rtrim usage (#174)#190
Open
will-b-tornsoft wants to merge 1 commit intojordanbrauer:masterfrom
Open
fix: BinaryCalculator::product() rtrim usage (#174)#190will-b-tornsoft wants to merge 1 commit intojordanbrauer:masterfrom
will-b-tornsoft wants to merge 1 commit intojordanbrauer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #174
Types of changes
What types of changes does your code introduce? Check/place an
xin all the boxes that apply:Description
Use of
rtrim($value, '0.,'), causes any value of 0 to the left of the decimal (ones-place and greater) to be trimmed off due to the way rtrim repeats removal until the first non-matching character.Motivation and Context
Fix BinaryCalculator::product() rtrim usage (#174)
Details in my comment on the issue.
How Has This Been Tested?
Locally by running tests: