fix: remove nation flags before translations#296
Open
chemio9 wants to merge 1 commit intojoshbuchea:masterfrom
Open
fix: remove nation flags before translations#296chemio9 wants to merge 1 commit intojoshbuchea:masterfrom
chemio9 wants to merge 1 commit intojoshbuchea:masterfrom
Conversation
joshbuchea
approved these changes
Mar 7, 2026
Owner
joshbuchea
left a comment
joshbuchea
left a comment
There was a problem hiding this comment.
@chemio9 thank you for opening this PR. You made some great points and I'd prefer to not offend people with this project, so if you can update this so it's current and fix the merge conflict, I'd be happy to approve this change. No worries at all if you're not interested for any reason. Thanks again for you contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags are considered as the symbol of a nation, instead of a language. Use flags to represent languages makes people feel offended sometimes (verbally or politically). What's more, some languages are widely spoken around the world. For instance, Chinese is spoken in China, Singapore, Chinese Hong Kong, etc, so do English, choosing only one flag to represent these languages may offend speakers in other countries.
The PR removes flags before the translations.
https://www.flagsarenotlanguages.com/blog/why-flags-do-not-represent-language/