Open
Conversation
- Related to #13390. - Add `less` and `less-plugin-clean-css` as NPM dev dependencies. - Add `buildThemesCssTask` to find themes with a `css/main.less` file and build the `css/min.css` file with the local LESS and non deprecated options (`--rewrite-urls=all --clean-css`). - Remove Makefile from existing theme plugins. - Update arDominion to use `css/min.css` instead of `css/main.css`. - Update integration tests to use the new build CSS task.
- Update NPM globally. - Do not install `less` globally - Install local NPM dependencies. - Run new build themes task. - Add `npm_deps` named volume to avoid overwriting `node_modules`. - Add `npm_deps` and `node_modules` volumes to `nginx` container.
For testing purposes as it's not maintained anywhere.
- Add Bootstrap 5 and jQuery 3.6 to NPM dependencies.
- Initialize theme plugin with:
- Basic configuration.
- Layout templates using and adapted to Bootstrap 5, and without other
components (JS and CSS from view. yml files).
- Layout partials (start and end) to avoid duplication.
- WIP image for themes form.
jraddaoui
force-pushed
the
dev-test/issue-13530-b5-themes
branch
19 times, most recently
from
e9cfa1a to
5f6811d
Compare
- Runs on PRs targeting `qa/**` branches and which source branch
starts with `dev-test/`.
- Waits for all the other checks to complete successfully before start.
- Configures a SSH connection to a running AtoM server:
- The host name must match the branch name. E.g.: for a branch named
`dev-test/issue-12345-foo-bar` the host must be
`issue-12345-foo-bar.atom.artefactual.net`.
- It must accept connections using the DO_SSH_KEY secret.
- It must have an AtoM instance configured and running.
- The workflow performs the following steps on the existing instance:
- Stop services (nginx, php7.4-fpm and atom-worker).
- Fetch latest changes from the PR source branch.
- Update dependencies (NPM and Composer).
- Clear Symfony cache.
- Purge (--demo).
- Update themes CSS.
- Start services (allowing more than 3 atom-worker restarts per day).
jraddaoui
force-pushed
the
dev-test/issue-13530-b5-themes
branch
from
5f6811d to
c3e7dc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.