chore: remove duplicate idn-email test and fix ambiguous test descriptions#881
Open
AcEKaycgR wants to merge 1 commit intojson-schema-org:mainfrom
Open
chore: remove duplicate idn-email test and fix ambiguous test descriptions#881AcEKaycgR wants to merge 1 commit intojson-schema-org:mainfrom
AcEKaycgR wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
AcEKaycgR
force-pushed
the
chore/format-test-cleanups
branch
from
99e6072 to
92269c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While auditing the format test suites, I noticed a few test descriptions that were misleading, lacked precise RFC terminology, or were direct duplicates.
This is a PR to clean up these specific descriptions to better align with the explicit structural constraints of their respective RFCs. No validation logic or test
"data"strings have been altered.Changes made (applied across all relevant draft folders):
idn-email: Removed the duplicate test case for"2962". Combined the description of the remaining case to"an invalid e-mail/idn e-mail address".ipv6: Changed the description of12345::from"out-of-range values"to"a group with 5 hex digits is invalid". This accurately reflects that it is an ABNF structural failure, rather than a semantic range check.iri: Changed"an invalid IRI based on IPv6"to"an IPv6 address without enclosing brackets is invalid"to accurately reflect the port parsing failure.uri: Removed a stray trailing space in the description"a valid URL ".This ensures the test suite documentation remains highly precise for future implementers.
(cc: @jviotti @jdesrosiers)