Enhancing styling with Pico CSS and adding some features#1672
Enhancing styling with Pico CSS and adding some features#1672jdesrosiers merged 14 commits intojson-schema-org:mainfrom
Conversation
|
This isn't quite what I was expecting. There's so little difference between this and what I had, I'm questioning whether pico is necessary. You're customizing pico so much, is there anything left of pico? The point of something like pico (or water) is that it provides all the general styling and we can keep our stylesheet very simple and a cover only a few customizations specific to us. For example, I expect the code block titles and toc to be in our stylesheet, but I don't expect to see things like headings. I expect maybe some pico css variables being set, but this looks like it's replacing most of what I expect pico to give us. |
|
I understand now where is the mistake |
|
I'll leave the newest update for you to see whenever you are free @jdesrosiers , @gregsdennis
|
|
I pushed some changes cleaning up more more stuff that should be handled by pico. |
|
Great improvements! |
|
Hi, @jdesrosiers |
|
You implemented the padding in a place that only applies when the screen is larger. I updated the solution so that it always applies. I also addressed a problem where wide tables could make the whole page scroll horizontally. Now only the table scrolls. |
|
I think we have a good baseline now and can do some customization from here. Honestly, I'm not too happy with the way it looks. It doesn't feel like a standards document to me. I especially hate the neon blue primary link color. It looks more like a Las Vegas show than a standards document. Pico has a lot of variables we can use to tweak the look and feel. Let's see what we can do to make it look more serious. |
|
Oh.. my bad, I made it so it was required to have a screen more than 64rem, thanks for the observation |
|
I made the links looks better with changing color to make the whole thing looks more standard, any other recommendations? |
|
It looks better, but I'm not sure about removing the underline on links. That's part of user feedback to know its clickable. I see pico uses a different color for hover, but the colors are so similar now that it's barely noticeable. I think since we don't have the UI experience to do this right, we should stick with the traditional underline. I wonder if a different font will make it look more like a standard. Do you think you can do something about the horizontal scroll that shows up in the left column sometimes. Screencast.From.2026-03-02.10-31-39.mp4 |
|
Ok deal |
|
Yes, I think it looks great now. |
gregsdennis
left a comment
There was a problem hiding this comment.
This looks really good, guys.
I did notice that we have some places where keywords link to their respective sections, but these are the exception. Usually they're not linked.
I've added an item to #1612 to cover this, so not critical for this work.
|
I'm going to go ahead and merge. I'm sure we're find more things that need tweaking, but I think this is a good solid base at this point. |



I replaced water.css with Pico CSS for more modern styling and fixing the ToC format and highlighting, also enhancing the code block, That was enhancing of the pull request #1671
This is the current state: