Add section for one of in enum#193
Open
Girishbari wants to merge 3 commits intojson-schema-org:mainfrom
Open
Conversation
Author
|
@erosb let me know what you think |
erosb
reviewed
Nov 13, 2025
content/01-Getting-Started/04-Enumerated-Values/instructions.mdx
Outdated
Show resolved
Hide resolved
erosb
requested changes
Nov 13, 2025
content/01-Getting-Started/04-Enumerated-Values/instructions.mdx
Outdated
Show resolved
Hide resolved
content/01-Getting-Started/04-Enumerated-Values/instructions.mdx
Outdated
Show resolved
Hide resolved
Collaborator
|
Hello @JeelRajodiya can you please review this PR? |
erosb
approved these changes
Nov 14, 2025
Collaborator
erosb
left a comment
erosb
left a comment
There was a problem hiding this comment.
This looks food for me, thank you for your work @Girishbari !. @JeelRajodiya can you please review it as well?
JeelRajodiya
approved these changes
Nov 26, 2025
Member
JeelRajodiya
left a comment
JeelRajodiya
left a comment
There was a problem hiding this comment.
approved. I'll merge it after testing locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR adds a paragraph of how once can make use of oneOf instead enum
Issue Number:
enumwithanyOf/oneOf#70Screenshots/videos:
Does this PR introduce a breaking change?
No