fix: documentation sidebar component to show on mobile#670
fix: documentation sidebar component to show on mobile#670junnjiee wants to merge 3 commits intojuliencrn:masterfrom
Conversation
🦋 Changeset detectedLatest commit: a6f3e37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks @junnjiee16 for creating that PR. I am new to this project in terms of contributing to it but i would like to challenge the changes you've made because the main navigation on the homepage now differs between mobile and tablet/desktop view. I would suggest to
|
|
In #665 we try to figure out if it makes sense to work on PRs in this repository at all because it seems to be dead. But who knows. Anyway: if you want to make this PR work you have to add a changeset. I went through the same process couple of weeks ago :) Feel free to scroll through #665 to get some information about it. |
|
Hi @iwan-uschka, thank you for the suggestions. I committed changes to remove the main navigation links from the page as well as include a patch changeset
For this suggestion, I couldn't find a way to do it. Since |
Fixes #664 (There was no way to access the
LeftSidebarcomponent in mobile view, which contained links to each hook documentation)LeftSidebarwasn't able to show on mobile ashidden md:blockwas applied on the component itselfI changed the component to take in an extra
classNameprop, so that only selectedLeftSidebarcomponents will be hidden.I also removed the Features and Documentation nav links in the
MobileNavcomponent - it was weird having the Documentation and Introduction link together, since it led to the same page.Edited the marketing layout so that
LeftSidebaris able to be shown on the home page tooBefore:

After:
