Open
Conversation
lachieh
approved these changes
Feb 8, 2025
lachieh
left a comment
lachieh
left a comment
There was a problem hiding this comment.
Small change regarding string coercion but looks good to me. @juliencrn will have to give final approval since they own it but I figure it doesn't hurt to have extra eyes on.
| <> | ||
| {Array.from({ length: 5 }).map((_, index) => ( | ||
| <Section key={index + 1} title={`${index + 1}`} /> | ||
| <Section key={index + 1} title={(index + 1).toFixed()} /> |
There was a problem hiding this comment.
Best to use .toString() here. This would cause a difference in output. Template literals coerce their values to strings, which calls the .toString() method instead of .toFixed()
let x = 123.456
x.toString() // "123.456"
x.toFixed() // "123"
Suggested change
| <Section key={index + 1} title={(index + 1).toFixed()} /> | |
| <Section key={index + 1} title={(index + 1).toString()} /> |
|
|
||
| expect(document.body.style.paddingRight).toBe(`${scrollbarWidth}px`) | ||
| expect(document.body.style.paddingRight).toBe( | ||
| `${scrollbarWidth.toFixed()}px`, |
lachieh
suggested changes
Feb 8, 2025
lachieh
left a comment
lachieh
left a comment
There was a problem hiding this comment.
Should probably have marked for changes
🦋 Changeset detectedLatest commit: 7b74d4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate
typescriptdependency versions to a single one referenced in the rootpackage.json. Before this change, they were two versions of TypeScript: 5.4.3 and 5.3.3. Now we have only one version of TypeScript: 5.4.3. To avoid running into warnings likewhen calling pnpm lint i had to update @typescript-eslint to 7.18.0. This required some fixes to add to the codebase.
I also added VS Code setting to prefer TypeScript version of workspace in IDE instead of the default one of VS Code itself.