feat(useCountdown): add autoStart and onFinish options#716
Open
joaobibiano wants to merge 2 commits intojuliencrn:masterfrom
Open
feat(useCountdown): add autoStart and onFinish options#716joaobibiano wants to merge 2 commits intojuliencrn:masterfrom
joaobibiano wants to merge 2 commits intojuliencrn:masterfrom
Conversation
🦋 Changeset detectedLatest commit: b3510de The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds two new options to
useCountdownto simplify consumption and avoid extrauseEffectusage in user-land:autoStart?: booleanto start the countdown on mountonFinish?: () => voidcallback fired whencountStopis reachedType of change
What changed
useCountdownoptions and implementationautoStartandonFinishTesting
pnpm -C packages/usehooks-ts test useCountdownpnpm -C packages/usehooks-ts lint(fails in this environment due to missingeslint-plugin-import)