Better handling of an empty container status in confirm_remote_startup#1370
Open
OrenZ1 wants to merge 3 commits intojupyter-server:mainfrom
Open
Better handling of an empty container status in confirm_remote_startup#1370OrenZ1 wants to merge 3 commits intojupyter-server:mainfrom
confirm_remote_startup#1370OrenZ1 wants to merge 3 commits intojupyter-server:mainfrom
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
Author
|
Discussed in #1357 |
kevin-bates
added
bug
gateway-provisioners
Author
|
Hey! Is there any update on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified
confirm_remote_startupmethod to make handling of empty container status better, so that if a kernel pod dies while still in startup, the startup process will fail and the user won't have to wait for timeout.