Integrate geoportal extensions leaflet#1042
Open
HaudinFlorence wants to merge 31 commits intojupyter-widgets:masterfrom
Open
Integrate geoportal extensions leaflet#1042HaudinFlorence wants to merge 31 commits intojupyter-widgets:masterfrom
HaudinFlorence wants to merge 31 commits intojupyter-widgets:masterfrom
Conversation
davidbrochart
requested changes
Aug 23, 2022
Member
davidbrochart
left a comment
davidbrochart
left a comment
There was a problem hiding this comment.
Should these layers be part of https://github.com/geopandas/xyzservices?
Contributor
Author
|
update galata reference |
HaudinFlorence
force-pushed
the
integrate_geoportal_extensions_leaflet
branch
from
d6b4259 to
d2f4b69
Compare
Contributor
Author
|
please update galata references |
…s, and update the SearchEngine, MousePosition and Route controls.
HaudinFlorence
force-pushed
the
integrate_geoportal_extensions_leaflet
branch
from
d2f4b69 to
9a580e8
Compare
davidbrochart
requested changes
Sep 13, 2022
Co-authored-by: David Brochart <david.brochart@gmail.com>
Co-authored-by: David Brochart <david.brochart@gmail.com>
Co-authored-by: David Brochart <david.brochart@gmail.com>
Co-authored-by: David Brochart <david.brochart@gmail.com>
Co-authored-by: David Brochart <david.brochart@gmail.com>
Co-authored-by: David Brochart <david.brochart@gmail.com>
Co-authored-by: David Brochart <david.brochart@gmail.com>
Co-authored-by: David Brochart <david.brochart@gmail.com>
Co-authored-by: David Brochart <david.brochart@gmail.com>
HaudinFlorence
force-pushed
the
integrate_geoportal_extensions_leaflet
branch
from
6f8af2f to
8ed7407
Compare
HaudinFlorence
force-pushed
the
integrate_geoportal_extensions_leaflet
branch
from
8ed7407 to
39dafb8
Compare
This reverts commit 39dafb8.
Contributor
Author
|
please update galata references |
davidbrochart
force-pushed
the
integrate_geoportal_extensions_leaflet
branch
from
231dacc to
bc31e3c
Compare
Member
|
I just rebased. |
HaudinFlorence
force-pushed
the
integrate_geoportal_extensions_leaflet
branch
from
bc31e3c to
3791744
Compare
Contributor
Author
Thanks ! |
Contributor
Author
|
I don't know how to fix the widgets rendering failing tests. |
Contributor
Author
There is a PR under review open to integrate the IGN tile layers in the providers of xyzservices : geopandas/xyzservices#126 |
Member
There might be a bug in the geoportal extension for leaflet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the controls of the geoportal extensions leaflet. This includes :
GeoportalLayerSwitcher: a control to switch between different tile layersGeoportalSearchEngine: a control to locate an address, a cityGeoportalRoute: a control to calculate itineraries (by car or by walking)GeorportalMousePosition: a control to get the coordinates of a position on a mapGeoportalElevationPath: a control to plot the altimetric profile along a given itineraryGeoportalIsocurve: a control to determine an aera around a position covering a given distance or a duration given a locomotion mean (by car or by walking)GeoportalReverseGeocode: a control to get the adress or the parcel on a given selected place on a map