ci: add draw controls test#1178
ci: add draw controls test#1178maartenbreddels wants to merge 1 commit intojupyter-widgets:masterfrom
Conversation
6e5c205 to
2d25d64
Compare
This is using solara to run the test with a live frontend.
2d25d64 to
4dc6665
Compare
|
Failure is most likely not due to this PR. |
|
Thanks Maarten! I'm a bit skeptical about adding a new way to do visual regression testing to the repo. I'd prefer we either stick to galata or we move entirely to using solara testing.
you more or less have the same API with playwright |
|
Hi Martin,
Yes, but I've noticed pure python people having no idea what to do with the That said, I totally understand not wanting two systems. I could probably rewrite the notebook tests to use the solara test framework, but that would mean we don't have such a nice HTML report, since that is not available for Python yet: microsoft/playwright-python#1296 Let me know what you think? Do you think its worth to give up the HTML report to have the option to do more complex UI tests from Python? cheers, Maarten |
This is using solara to run the test with a live frontend.
These things are difficult to test with galata, since we test user interaction.
In light of a future PR (see #1165 for details) I think it's good to test one of the more complex widgets.