feat(tests): add new cypress test suites and update existing tests for matrix coverage - #1555
Open
preetamrevankar wants to merge 22 commits into
Open
feat(tests): add new cypress test suites and update existing tests for matrix coverage#1555preetamrevankar wants to merge 22 commits into
preetamrevankar wants to merge 22 commits into
Conversation
…t testIds selectors
- Add defaultBillingAddress constant to utils.ts and reuse across test files
- Replace hardcoded profile IDs with connectorProfileIdMapping references
- Refactor mandate-card-flow-cybersource to use beforeEach for shared state setup
- Use cy.get('#submit').should('be.visible').click() consistently
- Restore removed comments in run-automation-test.yml
- Remove section divider banner comments from locale-i18n.cy.ts
- Fix failing tests: rewrite sdk-error-handling network/timeout tests to use
cy.intercept for browser-level requests instead of cy.request; fix
keyboard-accessibility focus tests to use click() instead of focus().should('be-focused');
fix error-announcement test to touch field before submitting
- Remove default-values-prefill.cy.ts (unreliable prefill flow)
- Replace delete operator with removeObjectKey in terms-display and custom-card-terms
- Remove unused component-index.html and component.js support files
- Fix San Francisco spelling across utils.ts, billing-fields-visibility, mifinity
- Remove commented-out component block from cypress.config.js
- Replace 'any' with proper cardDetails type in types.ts
- Remove 'as string' casts from billing-fields-visibility.cy.ts
- Remove verbose AI-generated JSDoc from locale-i18n.cy.ts
- Use .should('be.visible') before .click() on submit in element-lifecycle-test
- Replace hardcoded billing address with defaultBillingAddress in dynamic-fields-comprehensive
…ake cardScheme optional - Fix broken indentation in createPaymentBody.billing.address (state-lastDoe fields were outside the address block, missing closing braces for address and billing) - Restore missing defaultBillingAddress export that was lost in previous edit - Make cardScheme optional in cardDetails type to avoid breaking pre-existing test call sites that don't pass cardScheme
waitForSDKReady now waits for the card input to be visible inside the iframe, ensuring React has fully mounted the card form and registered submitCallback before any test interaction begins. The empty form submission tests also gained an explicit card input visibility guard, a not-be-disabled check on the submit button, and a doubled error-assertion timeout (5 s -> 10 s) to eliminate the race condition where background SDK initialisations (e.g. Google Pay loading) delayed validation-error rendering beyond the old timeout.
…r matrix coverage
preetamrevankar
requested review from
AbhishekChorotiya,
ArushKapoorJuspay,
aritro2002,
sakksham7 and
seekshiva
as code owners
May 14, 2026 10:02
Contributor
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
preetamrevankar
added
the
DO NOT MERGE
aritro2002
approved these changes
Jun 1, 2026
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
# Conflicts: # cypress-tests/cypress/e2e/01-sdk-core/layout-accordion.cy.ts # cypress-tests/cypress/e2e/01-sdk-core/layout-grid-tabs.cy.ts # cypress-tests/cypress/e2e/01-sdk-core/layout-spaced-accordion.cy.ts # cypress-tests/cypress/e2e/01-sdk-core/layout-tabs.cy.ts # cypress-tests/cypress/e2e/01-sdk-core/locale-i18n.cy.ts # cypress-tests/cypress/e2e/01-sdk-core/submit-button-states.cy.ts # cypress-tests/cypress/e2e/01-sdk-core/themes.cy.ts # cypress-tests/cypress/e2e/02-cards/cobadge-card-flow-cybersource.cy.ts # cypress-tests/cypress/e2e/02-cards/mandate-card-flow-cybersource.cy.ts # cypress-tests/cypress/support/cards.ts
Contributor
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
1 similar comment
Contributor
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cards.tssupport data, updatedpaymentMethods.jsonfixtures, and improvedeslint.config.cjs,TestUtils.res,Input.res,PaymentField.res, andBankDebitModal.res#1597
Type of Change
Test Coverage
New test files added:
cypress/e2e/02-cards/09-card-3ds-adyen.cy.tscypress/e2e/03-bank-transfers/02-ach-stripe.cy.tscypress/e2e/03-bank-transfers/03-sepa-adyen.cy.tscypress/e2e/04-alternative-payments/06-klarna-redirect.cy.tscypress/e2e/04-alternative-payments/07-afterpay-redirect.cy.tsNotes
.envandcypress.env.jsonare intentionally excluded from this PR as they contain secrets