Fix secret creation when a credentials.password is set#8
Open
ronaldosaheki wants to merge 5 commits intojust1689:mainfrom
Open
Fix secret creation when a credentials.password is set#8ronaldosaheki wants to merge 5 commits intojust1689:mainfrom
ronaldosaheki wants to merge 5 commits intojust1689:mainfrom
Conversation
…s-password Enable secret creation when a credentials.password is set
…s-password Fix template error when no credentials.password is providaded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds a new condition to render the secret template, also added a default empty credentials.password to avoid error:
Error: INSTALLATION FAILED: template: chisel/templates/secrets.yaml:1:87: executing "chisel/templates/secrets.yaml" at <.Values.credentials.password>: nil pointer evaluating interface {}.password
Note: Please add topic #hacktoberfest to the repo and label hacktoberfest-accepted to this PR/MR.