Skip to content

fix: subtitles for vlc.exe#289

Open
ibz096 wants to merge 1 commit intojustchokingaround:mainfrom
ibz096:vlc-sub-fix-windows
Open

fix: subtitles for vlc.exe#289
ibz096 wants to merge 1 commit intojustchokingaround:mainfrom
ibz096:vlc-sub-fix-windows

Conversation

@ibz096
Copy link
Contributor

@ibz096 ibz096 commented Oct 21, 2025

Modifed the the vlc case branch to use the $player variable instead of using the hard coded vlc command and updated the branch case from vlc) to vlc | vlc.exe) to capture vlc.exe

@ibz096 ibz096 changed the title fixed: subtitles for vlc.exe fix: subtitles for vlc.exe Oct 21, 2025
@ibz096
Copy link
Contributor Author

ibz096 commented Oct 23, 2025

The colon in the second sed pattern below should be replaced by the variable $separator.
I'm not sure the affect of setting the separator value to '#' so I am suggesting to do it in the vlc|vlc.exe) branch

sed 's/https\\:/https:/g; s/:\([^\/]\)/#\1/g'
sed 's/https\:/https:/g; s/:([^\/])/#\1/g'
---------------------------^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments