Skip to content

dynamic query invalidation for ConfigMaps and Secrets #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RafsanNeloy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dynamic query invalidation for ConfigMaps and Secrets #398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bdc508
dynamic query invalidation
RafsanNeloy Jan 28, 2026
4c7b1e9
Merge branch 'karmada-io:main' into working2
RafsanNeloy Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions ui/apps/dashboard/src/pages/multicloud-resource-manage/config/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,14 @@ const ConfigPage = () => {
`${msg}${i18nInstance.t('a6d38572262cb1b1238d449b4098f002', '配置成功')}`,
);
hideEditor();
if (editor.mode === 'create') {
await queryClient.invalidateQueries({
queryKey: ['GetConfigMaps'],
exact: false,
});
}
await queryClient.invalidateQueries({
queryKey: [
filter.kind === ConfigKind.ConfigMap
? 'GetConfigMaps'
: 'GetSecrets',
Comment on lines +158 to +160
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid using 'magic strings' for query keys, it's a good practice to define 'GetConfigMaps' and 'GetSecrets' as constants. These constants could be placed in a shared file (e.g., types.ts or a new queryKeys.ts) and then imported for use here and in the ConfigMapTable and SecretTable components where the queries are defined. This ensures consistency and simplifies future refactoring.

],
exact: false,
});
} else {
await messageApi.error(
`${msg}${i18nInstance.t('03d3b00687bbab3e9a7e1bd3aeeaa0a4', '配置失败')}`,
Expand Down