-
Notifications
You must be signed in to change notification settings - Fork 156
update cluster failover analysis #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update cluster failover analysis #929
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @XiShanYongYe-Chang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the clarity and accuracy of the Karmada documentation regarding cluster failover mechanisms. It refines the explanation of how cluster taints are applied and managed, distinguishing between controller-managed Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation for cluster failover analysis. The main change is to clarify that Karmada no longer automatically adds NoExecute taints to unhealthy clusters; this is now a manual operation for users. The documentation for how NoSchedule taints are added is also updated. These changes are reflected in both the English and Chinese documentation files.
My review includes a few suggestions to improve clarity and fix a typo. I've pointed out some awkward phrasing in both versions of the failover-analysis.md document and a significant typo in the Chinese version. After addressing these minor issues, the documentation will be more accurate and easier to understand.
i18n/zh/docusaurus-plugin-content-docs/current/userguide/failover/failover-analysis.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/userguide/failover/failover-analysis.md
Outdated
Show resolved
Hide resolved
Signed-off-by: changzhen <[email protected]>
3eca945 to
23d8e23
Compare
|
/cc @RainbowMango |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: