Make tests rely on gradle dependencies & split out test deps#220
Merged
MrCreosote merged 1 commit intomainfrom Mar 9, 2026
Merged
Make tests rely on gradle dependencies & split out test deps#220MrCreosote merged 1 commit intomainfrom
MrCreosote merged 1 commit intomainfrom
Conversation
Member
MrCreosote
commented
Mar 9, 2026
- TypeGeneratorTest no longer has its own list of jars; it just uses whatever gradle builds for it.
- Split out test dependencies separately since they were handled separately in TGT, although...
- it turns out that for every test, TTBOMATT, setUp[Test]Jars and [build|prepare]ClassPath are both always called and nothing happens between the calls that would be affected by the missing test jars, so there's no reason for the class path function to have a side effect of adding a couple jars to the libDir. As such sU[T]J now handles all jar copying.
- that being said, these tests are hard to analyze...
- Keeping separate deps for eventual gradlization of the sdk modules.
* TypeGeneratorTest no longer has it's own list of jars; it just uses
whatever gradle builds for it.
* Split out test dependencies separately since they were handled
separately in TGT, although...
* it turns out that for every test, TTBOMATT, setUp[Test]Jars and
[build|prepare]ClassPath are both always called and nothing happens
between the calls that would be affected by the missing test jars, so
there's no reason for the class path function to have a side effect of
adding a couple jars to the libDir. As such sU[T]J now handles all jar
copying.
* that being said, these tests are hard to analyze...
* Keeping separate deps for eventual gradlization of the sdk modules.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
=========================================
Coverage 71.46% 71.46%
Complexity 703 703
=========================================
Files 46 46
Lines 3715 3715
Branches 666 666
=========================================
Hits 2655 2655
Misses 826 826
Partials 234 234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.