Skip to content

Make tests rely on gradle dependencies & split out test deps#220

Merged
MrCreosote merged 1 commit intomainfrom
sdkdev
Mar 9, 2026
Merged

Make tests rely on gradle dependencies & split out test deps#220
MrCreosote merged 1 commit intomainfrom
sdkdev

Conversation

@MrCreosote
Copy link
Member

  • TypeGeneratorTest no longer has its own list of jars; it just uses whatever gradle builds for it.
  • Split out test dependencies separately since they were handled separately in TGT, although...
  • it turns out that for every test, TTBOMATT, setUp[Test]Jars and [build|prepare]ClassPath are both always called and nothing happens between the calls that would be affected by the missing test jars, so there's no reason for the class path function to have a side effect of adding a couple jars to the libDir. As such sU[T]J now handles all jar copying.
    • that being said, these tests are hard to analyze...
  • Keeping separate deps for eventual gradlization of the sdk modules.

* TypeGeneratorTest no longer has it's own list of jars; it just uses
whatever gradle builds for it.
* Split out test dependencies separately since they were handled
separately in TGT, although...
* it turns out that for every test, TTBOMATT, setUp[Test]Jars and
[build|prepare]ClassPath are both always called and nothing happens
between the calls that would be affected by the missing test jars, so
there's no reason for the class path function to have a side effect of
adding a couple jars to the libDir. As such sU[T]J now handles all jar
copying.
    * that being said, these tests are hard to analyze...
* Keeping separate deps for eventual gradlization of the sdk modules.
@MrCreosote MrCreosote requested a review from briehl March 9, 2026 01:01
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.46%. Comparing base (5b24cc5) to head (7dfec7f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #220   +/-   ##
=========================================
  Coverage     71.46%   71.46%           
  Complexity      703      703           
=========================================
  Files            46       46           
  Lines          3715     3715           
  Branches        666      666           
=========================================
  Hits           2655     2655           
  Misses          826      826           
  Partials        234      234           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@briehl briehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MrCreosote MrCreosote merged commit 9fa0d36 into main Mar 9, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants