Conversation
|
LGTM label has been added. DetailsGit tree hash: d9923af3dfee347737df83329aef52217b7d40d5 |
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
|
||
| ## What does kcp stand for / how to spell it? | ||
|
|
||
| `kcp` stands for "Kube for Control Plane" and should always be written in lowercase letters. |
There was a problem hiding this comment.
Afaik our official position is that it doesn't stand for anything.
There was a problem hiding this comment.
I thought so too, but then I found https://github.com/kcp-dev/kcp/blob/main/cmd/kcp/kcp.go#L51.
There was a problem hiding this comment.
I also remember someone telling me that kcp effectively stands for nothing and CERTAINLY NOT "Kubernetes control plane", but since then I heard many folks use the "kube for control plane" mantra.
No real opinion on my side.
There was a problem hiding this comment.
I would vote for kcp - Kubernetes-like Control Planes. This was clicked in my head for a long time.
I leave the final vote for @sttts :)
There was a problem hiding this comment.
I can agree with MJ's earlier proposal ("kcp - Kubernetes-like Control Planes") if CNCF allows it.
There was a problem hiding this comment.
I checked with CNCF folks and the inofficial statement through the grapevines was:
- [this decision] should not need CNCF approval
- [kcp devs] must just make sure to follow kcp governance
There was a problem hiding this comment.
@xmudrii Is the decision here done, did all maintainers vote?
mjudeikis
left a comment
There was a problem hiding this comment.
just close the one pending and merge
| Short: "kubectl plugin for kcp", | ||
| Long: help.Doc(` | ||
| KCP is the easiest way to manage Kubernetes applications against one or | ||
| kcp is the easiest way to manage Kubernetes applications against one or |
There was a problem hiding this comment.
can we remove this Kubernetes applications against. Applications are confusing.
ALl thi section is somehow wrong.
There was a problem hiding this comment.
I replaced it with the current short intro we have in our Readme/docs.
There was a problem hiding this comment.
Can we replace the doc here with this? https://github.com/xrstf/kcp/blob/47233a3c7b3f7fcb1c0e2ed9f9c8a04801bc9cf9/cmd/kcp/kcp.go#L53-L63
|
|
||
| ## What does kcp stand for / how to spell it? | ||
|
|
||
| `kcp` stands for "Kube for Control Plane" and should always be written in lowercase letters. |
There was a problem hiding this comment.
I would vote for kcp - Kubernetes-like Control Planes. This was clicked in my head for a long time.
I leave the final vote for @sttts :)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@xrstf: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| Short: "kubectl plugin for kcp", | ||
| Long: help.Doc(` | ||
| KCP is the easiest way to manage Kubernetes applications against one or | ||
| kcp is the easiest way to manage Kubernetes applications against one or |
There was a problem hiding this comment.
Can we replace the doc here with this? https://github.com/xrstf/kcp/blob/47233a3c7b3f7fcb1c0e2ed9f9c8a04801bc9cf9/cmd/kcp/kcp.go#L53-L63
| leader election is enabled). It is accessible via `/clusters/system:admin`. | ||
|
|
||
| # Workspace Type Extensions and Constraints | ||
| ## Workspace Type Extensions and Constraints |
There was a problem hiding this comment.
Was this deliberate? I feel like workspace types being their own "section" would make sense.
| 9. Open a PR; get it reviewed and merged. | ||
|
|
||
| # 3. Update kcp-dev/client-go | ||
| ## 3. Update kcp-dev/client-go |
There was a problem hiding this comment.
I think we can scrap the changes for rebasing-kubernetes in favour of the doc update PR and fix casing there as well? Just so it doesn't cause a merge conflict. Up to you though.
|
|
||
| ## What does kcp stand for / how to spell it? | ||
|
|
||
| `kcp` stands for "Kube for Control Plane" and should always be written in lowercase letters. |
There was a problem hiding this comment.
@xmudrii Is the decision here done, did all maintainers vote?
|
@ntnn The vote is still ongoing, I'll try pinging some folks directly by the end of the week. |
Summary
It irks me that it's sometimes
kcp, sometimesKCPand in extreme cases evenKcp. For no technical reason other than consistency, I vote that we enshrine the correct spelling (all lowercase) in the FAQ and adjust all files accordingly.This PR also fixes the rebasing docs a bit and adds a note that they are probably severely outdated since we moved to monorepo. The sample screenshot of GitHub is now included as well and shrunk by optipng by nearly 50% :)
I did not touch the boilerplate header as I am not sure about the CNCF rammifications, but I would personally of course also change them. If we can.
What Type of PR Is This?
/kind cleanup
Release Notes