Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major enhancement to the global search and TUI filtering capabilities:
compute.route) — searches by name, description, destination range, network, and next hop with smart next-hop resolution (gateway, instance, IP, VPN tunnel, ILB, peering)Tabin global search to switch between exact and fuzzy mode (e.g. "prd" matches "production")|for OR,-prefix for NOT (e.g.web|api prod -staging)MatchesAny()to search across name + detail fields (description, IPs, tags, etc.)Filter syntax examples
web prodweb|api-devdb|sql prod -stagingChanges
New files
internal/tui/filter.go— filter expression parser (AND/OR/NOT)internal/tui/filter_test.go— 41 tests for the filter parserinternal/gcp/search/routes.go— VPC routes search providerinternal/gcp/search/routes_test.go— route provider testsModified files
internal/gcp/types.go— addedRoutestruct, enrichedAddressandFirewallRulestructsinternal/gcp/resources.go— addedListRoutes(), enrichedListAddresses()andListFirewallRules()internal/gcp/search/types.go— addedKindRoute,Fuzzyfield onQuery, fuzzy matching inMatches()/MatchesAny()internal/tui/search_view.go— fuzzy toggle (Tab), filter syntax, highlight, route provider registrationinternal/tui/direct.go— usesparseFilter/matchesfor advanced filteringinternal/tui/instance_view.go— usesparseFilter/matchesfor advanced filteringinternal/tui/connectivity_view.go— usesparseFilter/matchesfor advanced filteringinternal/tui/vpn_view.go— usesparseFilter/matchesfor advanced filteringinternal/tui/project_selector.go— usesparseFilter/matchesfor advanced filteringinternal/tui/ip_lookup_view.go— usesparseFilter/matchesfor advanced filteringinternal/gcp/search/addresses.go— matches on description, details include subnetwork/usersinternal/gcp/search/firewall_rules.go— matches on description/source ranges/target tags/allowedREADME.md— updated with TUI section, filtering docs, routes, enriched resource tableTest plan
go build ./...compiles cleanlygo test ./internal/gcp/search/... -v— all provider tests pass (116+ tests)go test ./internal/tui/... -v— all TUI tests pass (41 tests including filter parser)compass interactive, press/, typedb test— should matchdb-test-1compass interactive, press/, typedb|test— should matchdb-test-1Shift+S, search for a term, pressTabto toggle fuzzy, verify label changes/, typecompute.instance prod -dev, verify AND/OR/NOT filtering🤖 Generated with Claude Code