Skip to content

Improve edge case coverage of load_node magic#5418

Draft
noklam wants to merge 4 commits intomainfrom
feat/load-node-enhacement
Draft

Improve edge case coverage of load_node magic#5418
noklam wants to merge 4 commits intomainfrom
feat/load-node-enhacement

Conversation

@noklam
Copy link
Contributor

@noklam noklam commented Mar 3, 2026

Description

Fix #5417, there are details what this PR try to fix. In addition, the test case should be self-explanatory test_load_node_executes_with_same_module_helper_dependency

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Nok Lam Chan <mediumnok@gmail.com>
@noklam noklam requested a review from merelcht as a code owner March 3, 2026 23:08
@noklam noklam added this to Kedro 🔶 Mar 3, 2026
@noklam noklam marked this pull request as draft March 3, 2026 23:08
@noklam noklam self-assigned this Mar 3, 2026
noklam added 3 commits March 3, 2026 23:33
Signed-off-by: Nok Lam Chan <mediumnok@gmail.com>
Signed-off-by: Nok Lam Chan <mediumnok@gmail.com>
Signed-off-by: Nok Lam Chan <mediumnok@gmail.com>
@rashidakanchwala rashidakanchwala moved this to To Do in Kedro 🔶 Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Do

Development

Successfully merging this pull request may close these issues.

Improve %load_node to cover edge case when functions are defined in same module

2 participants