Tests and fixes AIP delete permission checks on relatives, resolves incorrect nested iteration on transactional reports

[eduardojst10]

DeleteRodaObjectPluginsUtils.java

• corrected handling of AIP deletion when sublevel AIPs exist and the user lacks DELETE permission on one or more children
• prevents unintended orphans when parameter dontCheckRelatives=false

DeleteAIPPermissionTest.java

Test scenarios

1. Delete parent blocked by child permission:### DeleteRodaObjectPluginsUtils.java

• corrected handling of AIP deletion when sublevel AIPs exist and the user lacks DELETE permission on one or more children
• prevents unintended orphans when parameter dontCheckRelatives=false

DeleteAIPPermissionTest.java

Test scenarios

1. Delete parent blocked by child permission:
   • user has DELETE permission on parent but not on child
   • dontCheckRelatives=false
   • both child and parent are not deleted
2. Delete parent and child with full permissions:
   • user has DELETE permission on both parent and child
   • dontCheckRelatives=false
   • both child and parent are deleted
3. Delete child, parent without DELETE permissions:
   • child has no sublevels
   • user has DELETE permission on child but not on parent
   • dontCheckRelatives=false
   • child is deleted
   • parent is not deleted
4. Delete parent ignoring relatives:
   • user has DELETE permission on parent but not on child
   • dontCheckRelatives=true
   • parent is deleted
   • child is orphan

Additionally tests were made through the use of curl and user bearer token functionality. Since delete permissions of AIP parent are still controlled in roda-wui (AIPController)

Addresses issue #896

RODATransactionManager.java

• avoid transactional instability caused by concurrent report iteration
• replaced incorrect nested loop over transactional reports with stream maintaining logic of rollback skip

[dosubot]

Related Documentation

Checked 5 published document(s) in 1 knowledge base(s). No updates required.

^{How did I do? Any feedback?}  

[006627]

The necessary test annotation to run this test during compilation is missing.