fix: properly handle paths in init-container.sh#136
Merged
Conversation
darcywong00
approved these changes
Feb 19, 2025
Contributor
darcywong00
left a comment
darcywong00
left a comment
There was a problem hiding this comment.
lgtm
Why would the cwd be different now?
Allows CDN refresh to run on production, which called `resources/init-container.sh` instead of `./init-container.sh`. Fixes: #135
mcdurdin
force-pushed
the
fix/135-cdnrefresh-path
branch
from
58bffa3 to
96a3c79
Compare
Member
Author
This has been broken for a long time. A longer term fix is to add We have some other cdn issues also, e.g. references to images etc in css stylesheets is difficult. |
This was referenced Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows CDN refresh to run on production, which called
resources/init-container.shinstead of./init-container.sh.Fixes: #135