Plan: Modernize @tko/utils#335
Draft
brianmhunt wants to merge 2 commits intomainfrom
Draft
Conversation
Phased modernization of @tko/utils — drop legacy polyfill probes, tighten types, preserve public API surface. Five independently shippable phases (A–E). Phase A is already implemented on modernize/utils-dead-polyfills and green on both browser and happy-dom projects. Out of scope: @tko/lifecycle refactor (#322), public API removal, the deferError/onError swallowing bug (separate branch). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Existing onErrorBehaviors.ts spec explicitly codifies the current behavior: when options.onError is installed, all TKO errors (including deferred ones) flow through it rather than escaping to window.onerror. That's the designed contract; my earlier flag was wrong. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
plans/modernize-utils.md— a phased modernization plan for@tko/utilsthat drops legacy polyfill probes, tightens types, and preserves the public API surface package-by-package.This PR is just the plan, opened as a draft for discussion before implementation PRs land.
Phases
modernize/utils-dead-polyfills)symbol,function,string,css— net -40 lines, 2698 browser + 2671 happy-dom tests passtasks.tsmicrotaskqueueMicrotaskis universalobject.tsObject.hasOwn(ES2022); delete@deprecated clonePlainObjectDeepmemoization.tsMapover{}dictionaryarray.tsidiomsarguments.length > 2 ? .bind(owner)patternOut of scope
@tko/lifecyclerefactor (#322) — separate plan.deferError/options.onErrorswallowing bug — spawned to its own branch to keep this scope surgical.Test plan
arguments.length > 2→ dropthisArgthird-arg pattern)🤖 Generated with Claude Code