Add hardware profile for ViewDisplay ESP32 Round TFT Knob 2.1"#266
Add hardware profile for ViewDisplay ESP32 Round TFT Knob 2.1"#266karl-petter wants to merge 1 commit intokoosoli:mainfrom
Conversation
Tested to compile on v1.0.0 RC2.16
|
Hi, please take a look at #290 |
|
Hi, I do not understand. Can you please explain? |
|
just wanted to say that there are changes to custom hardware just to make sure that it will not affect your changes, it would be good if you could retest them... but wait until we are close to release 1.0 |
|
Thanks again for the work on this and for opening multiple PRs to add device support. I really appreciate the effort. I did run into a few issues with this PR in its current form, so I ended up reworking it myself and have now pushed the updated version to the For future device-support PRs, the main things I need in order to merge them are:
If you base future device PRs on one of the newer hardware profiles already in Thanks again for contributing and helping expand device support. |
|
That said, you can now go over all your open PRs, I am done with the code cleanup of RC8 and ready to accept PRs |
|
Aah. Will take a look once I have time. Right now there is not much of that. But I found there is a known bug in EspHome regarding this particular display esphome/esphome#13140 |
As requested in this thread https://www.facebook.com/groups/HomeAssistant/permalink/4323991034538900/ by Erik Wolvers. ESPHome compiles the code generated based on this profile and ESPHomeDesigner v1.0.0 RC2.16. Do not have the hardware yet so cannot test if it actually works.