Skip to content

Add hardware profile for ViewDisplay ESP32 Round TFT Knob 2.1"#266

Open
karl-petter wants to merge 1 commit intokoosoli:mainfrom
karl-petter:add_support_for_viewdisplay-esp32-s3-uedx48480021
Open

Add hardware profile for ViewDisplay ESP32 Round TFT Knob 2.1"#266
karl-petter wants to merge 1 commit intokoosoli:mainfrom
karl-petter:add_support_for_viewdisplay-esp32-s3-uedx48480021

Conversation

@karl-petter
Copy link
Copy Markdown

As requested in this thread https://www.facebook.com/groups/HomeAssistant/permalink/4323991034538900/ by Erik Wolvers. ESPHome compiles the code generated based on this profile and ESPHomeDesigner v1.0.0 RC2.16. Do not have the hardware yet so cannot test if it actually works.

@karl-petter karl-petter marked this pull request as ready for review February 7, 2026 17:49
@koosoli
Copy link
Copy Markdown
Owner

koosoli commented Feb 14, 2026

Hi, please take a look at #290
This might be important for your testing of new profils

@karl-petter
Copy link
Copy Markdown
Author

Hi, I do not understand. Can you please explain?

@koosoli
Copy link
Copy Markdown
Owner

koosoli commented Feb 15, 2026

just wanted to say that there are changes to custom hardware just to make sure that it will not affect your changes, it would be good if you could retest them... but wait until we are close to release 1.0

@koosoli
Copy link
Copy Markdown
Owner

koosoli commented Mar 6, 2026

Thanks again for the work on this and for opening multiple PRs to add device support. I really appreciate the effort.

I did run into a few issues with this PR in its current form, so I ended up reworking it myself and have now pushed the updated version to the rc8 branch. Your PR was still useful as a reference, so thank you for that.

For future device-support PRs, the main things I need in order to merge them are:

  • The device YAML needs to follow the current package/profile format used on rc8
  • It should include the required placeholders, especially # __LAMBDA_PLACEHOLDER__
  • If the device supports touch, it should also include # __TOUCH_SENSORS_PLACEHOLDER__
  • Please avoid leaving things like show_test_card: true enabled
  • Backlight handling should follow the current display_backlight pattern used by the project, rather than older custom switch-based approaches
  • The profile should match the current hardware recipe conventions so it works with import/export and package processing without extra manual fixes
  • If possible, test the generated YAML with the current branch structure before opening the PR

If you base future device PRs on one of the newer hardware profiles already in rc8, that will make it much easier for me to review and merge them quickly.

Thanks again for contributing and helping expand device support.

@koosoli
Copy link
Copy Markdown
Owner

koosoli commented Mar 6, 2026

That said, you can now go over all your open PRs, I am done with the code cleanup of RC8 and ready to accept PRs

@karl-petter
Copy link
Copy Markdown
Author

Aah. Will take a look once I have time. Right now there is not much of that. But I found there is a known bug in EspHome regarding this particular display esphome/esphome#13140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants