displaysytem is korean transtlation#11
Open
hunylee wants to merge 11 commits intokosslab-kr:masterfrom
hunylee:master
Open
displaysytem is korean transtlation#11hunylee wants to merge 11 commits intokosslab-kr:masterfrom hunylee:master
hunylee wants to merge 11 commits intokosslab-kr:masterfrom
hunylee:master
Conversation
Author
|
displaysystem korean transtlation |
Author
|
back-end-angular_ko.md korean is transtlation |
Author
|
second back-end angular is second korean transtlated |
basicdisplaysystem_ko.md is delete
front-end-angular_ko.md is delete
yoonjs2
suggested changes
Oct 4, 2016
yoonjs2
left a comment
There was a problem hiding this comment.
@hunylee 님 제가 회사일로 리뷰를 늦게 확인해 드렸네요 죄송합니다. 보내주신것들을 죽 봤는데요 Approve해 드리기엔 이미 Merge된 다른 분들의 내용과 다음의 부분들이 너무 상이한것 같습니다.
- 문체
먼저 PR주신 분들은 "습니다"체로 통일하여 제출해 주시고 있습니다. 번역하신 문장들이 "한다. 있다"로 종결하는 문장으로 통일하여 제공하고 계시는데 다른분들처럼 친절하게 바꾸실 의향이 있으신가요? - 문장구조
직역하시고 바로 PR을 주시는것 같은데 보는 사람이 이해할수 있도록 의역을 추가하시거나 문장을 좀 매끄럽게 풀어서 작성해 주실수 있을까요? 예를들어: "ZeppelinContext 를 통해서, AngularJS view 가 바인드/언바인드 변수로 할 수 있다. 현재, **스파크 인터프리터 ( scala )**만 작업할 수 있다." 이렇게 번역을 해서 보내주셨는데 제 입장에서 문장을 이해하기가 좀 어렵습니다. 뭔가 한국어가 아니라 영어를 바로 한국으로 바꾸신것 같은데 약간만 좀더 손보실수 있는지요?
위와 같은 부분이 한두 문장이면 제가 그 라인을 표기해서 수정을 요청드리고 싶지만 문서 전체에 해당하고 있어 아무래도 님이 번역하시는 스타일을 다른 분들과 통일시켜 주시는걸 제가 요청드려야 할것 같습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/docs/displaysystem/basicdisplaysystem.md
https://zeppelin.apache.org/docs/displaysystem/back-end-angular.md
https://zeppelin.apache.org/docs/displaysystem/front-end-angular.md
What type of PR is it?
[Documentation ]
Todos
What is the Jira issue?
How should this be tested?
Outline the steps to test the PR here.
Screenshots (if appropriate)
Questions: