Skip to content

Preserve reference naming invariants - #3839

Merged
koxudaxi merged 4 commits into
fix/jsonschema-hardeningfrom
fix/reference-name-invariants
Sep 4, 2026
Merged

Preserve reference naming invariants#3839
koxudaxi merged 4 commits into
fix/jsonschema-hardeningfrom
fix/reference-name-invariants

Conversation

@koxudaxi

@koxudaxi koxudaxi commented Sep 2, 2026

Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: d09ea8a5-56fa-4f79-aebb-1ac44cdd1d09

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@koxudaxi koxudaxi changed the title fix/reference name invariants Preserve reference naming invariants Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📚 Docs Preview: https://pr-3839.datamodel-code-generator.pages.dev

@koxudaxi
koxudaxi force-pushed the fix/reference-name-invariants branch from ef42715 to ef6aa50 Compare September 2, 2026 06:01
@codspeed-hq

codspeed-hq Bot commented Sep 2, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 15.69%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 22 regressed benchmarks
✅ 16 untouched benchmarks
⏩ 98 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
test_perf_extreme_large_schema 11.3 s 14.3 s -21.18%
test_perf_all_options_enabled 4.1 s 5.1 s -18.91%
test_perf_kubernetes_style_pydantic_v2 1.9 s 2.4 s -18.77%
test_perf_deep_nested 3.9 s 4.7 s -18.47%
test_perf_complex_refs 1.5 s 1.8 s -18.34%
test_perf_multiple_files_input 2.5 s 3.1 s -17.99%
test_perf_large_models_pydantic_v2 2.7 s 3.2 s -17.64%
test_perf_stripe_style_pydantic_v2 1.4 s 1.7 s -17.35%
test_perf_openapi_large 2.3 s 2.7 s -17.31%
test_perf_duplicate_names 765.9 ms 925.9 ms -17.28%
test_perf_aws_style_openapi_pydantic_v2 1.5 s 1.8 s -17%
test_perf_large_models_typed_dict[total-false-requiredness] 446.3 ms 529.5 ms -15.71%
test_perf_large_models_single_module_stdout 628.7 ms 743 ms -15.39%
test_perf_graphql_style_pydantic_v2 609.6 ms 717.9 ms -15.08%
test_perf_large_models_typed_dict[legacy-requiredness] 445.9 ms 521.2 ms -14.45%
test_perf_large_models_pydantic_v2_builtin_double_quotes 585.8 ms 679.9 ms -13.84%
test_perf_large_models_pydantic_v2_noformat 551.8 ms 631.5 ms -12.63%
test_perf_large_models_pydantic_v2_builtin 556.1 ms 636.5 ms -12.63%
test_perf_ordinary_array_constraint_generation 926.2 ms 1,051.4 ms -11.91%
test_perf_openapi_large_pydantic_v2_builtin 569.4 ms 641.6 ms -11.25%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix/reference-name-invariants (96dca71) with fix/jsonschema-hardening (e2cfa53)

Open in CodSpeed

Footnotes

  1. 98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@koxudaxi
koxudaxi force-pushed the fix/reference-name-invariants branch 3 times, most recently from ec8d37d to e3b907b Compare September 2, 2026 06:30
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (fix/jsonschema-hardening@e2cfa53). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             fix/jsonschema-hardening     #3839   +/-   ##
============================================================
  Coverage                            ?   100.00%           
============================================================
  Files                               ?       257           
  Lines                               ?     58950           
  Branches                            ?      6500           
============================================================
  Hits                                ?     58950           
  Misses                              ?         0           
  Partials                            ?         0           
Flag Coverage Δ
unittests 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koxudaxi
koxudaxi force-pushed the fix/reference-name-invariants branch from e3b907b to 433bba0 Compare September 2, 2026 07:02
@koxudaxi
koxudaxi force-pushed the fix/reference-name-invariants branch 7 times, most recently from 9525e98 to 850d041 Compare September 4, 2026 04:24
@koxudaxi
koxudaxi force-pushed the fix/reference-name-invariants branch from 850d041 to 96dca71 Compare September 4, 2026 04:44
@koxudaxi
koxudaxi merged commit aa452c9 into main Sep 4, 2026
66 of 67 checks passed
@koxudaxi
koxudaxi deleted the fix/reference-name-invariants branch September 4, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant