Skip to content

Correct input format semantics - #3842

Merged
koxudaxi merged 7 commits into
fix/parser-model-reusefrom
fix/input-format-semantics
Sep 4, 2026
Merged

Correct input format semantics#3842
koxudaxi merged 7 commits into
fix/parser-model-reusefrom
fix/input-format-semantics

Conversation

@koxudaxi

@koxudaxi koxudaxi commented Sep 2, 2026

Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: ca9fc92c-8803-46e5-a95b-837da22fefad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@koxudaxi koxudaxi changed the title fix/input format semantics Correct input format semantics Sep 2, 2026
@koxudaxi
koxudaxi force-pushed the fix/input-format-semantics branch from 8fc96e7 to 4bbbc26 Compare September 2, 2026 06:01
@codspeed-hq

codspeed-hq Bot commented Sep 2, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 47.31%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 38 regressed benchmarks
⏩ 98 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
test_perf_empty_pydantic_v2_field_render_plans 6.9 ms 14.6 ms -52.54%
test_perf_simple_msgspec_unset_field_rendering 46.4 ms 97.1 ms -52.17%
test_perf_ordinary_array_constraint_generation 517.2 ms 1,054 ms -50.93%
test_perf_pattern_properties_adapter_reuse 2.1 ms 4.1 ms -50.18%
test_perf_large_models_single_module_stdout 382.5 ms 754 ms -49.27%
test_perf_deep_nested 2.4 s 4.7 s -49.08%
test_perf_extreme_large_schema 7.1 s 14 s -48.89%
test_perf_multiple_files_input 1.6 s 3.1 s -48.85%
test_perf_complex_refs 918.6 ms 1,792.1 ms -48.74%
test_perf_openapi_large 1.4 s 2.8 s -48.71%
test_perf_pydantic_field_name_resolution 5 ms 9.7 ms -48.7%
test_perf_large_models_pydantic_v2 1.7 s 3.2 s -48.49%
test_perf_all_options_enabled 2.6 s 5 s -48.49%
test_perf_inherited_required_fields[required-derived-first] 241.9 ms 469.1 ms -48.42%
test_perf_local_reference_file_resolution 33 ms 63.7 ms -48.23%
test_perf_large_models_typed_dict[total-false-requiredness] 274.9 ms 529.5 ms -48.09%
test_perf_duplicate_names 482.7 ms 929.1 ms -48.05%
test_perf_kubernetes_style_pydantic_v2 1.2 s 2.3 s -48.01%
test_perf_large_models_pydantic_v2_builtin_double_quotes 355.6 ms 682.2 ms -47.88%
test_perf_stripe_style_pydantic_v2 900.9 ms 1,726 ms -47.8%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix/input-format-semantics (f31e554) with fix/parser-model-reuse (2f62434)

Open in CodSpeed

Footnotes

  1. 98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@koxudaxi
koxudaxi force-pushed the fix/input-format-semantics branch from 4bbbc26 to 6b2f2f5 Compare September 2, 2026 06:11
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📚 Docs Preview: https://pr-3842.datamodel-code-generator.pages.dev

@koxudaxi
koxudaxi force-pushed the fix/input-format-semantics branch from 6b2f2f5 to 571843a Compare September 2, 2026 06:19
@koxudaxi
koxudaxi force-pushed the fix/input-format-semantics branch from f71c15a to bb59976 Compare September 2, 2026 06:30
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2f62434) to head (f31e554).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           fix/parser-model-reuse     #3842   +/-   ##
========================================================
  Coverage                  100.00%   100.00%           
========================================================
  Files                         257       257           
  Lines                       59286     59321   +35     
  Branches                     6550      6555    +5     
========================================================
+ Hits                        59286     59321   +35     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koxudaxi
koxudaxi force-pushed the fix/input-format-semantics branch 2 times, most recently from 7e5a760 to f31330b Compare September 2, 2026 07:31
@koxudaxi
koxudaxi force-pushed the fix/input-format-semantics branch from f31330b to 2385834 Compare September 2, 2026 07:36
@koxudaxi
koxudaxi force-pushed the fix/input-format-semantics branch 2 times, most recently from 76ad278 to ed06745 Compare September 2, 2026 09:06
@koxudaxi
koxudaxi force-pushed the fix/input-format-semantics branch from ed06745 to cf0d3c5 Compare September 4, 2026 02:08
@koxudaxi
koxudaxi force-pushed the fix/input-format-semantics branch 3 times, most recently from b8ae2e7 to ef48ac9 Compare September 4, 2026 03:43
@koxudaxi
koxudaxi force-pushed the fix/input-format-semantics branch from dcb9ae7 to a8db2a5 Compare September 4, 2026 03:47
@koxudaxi
koxudaxi force-pushed the fix/input-format-semantics branch 2 times, most recently from bf217e8 to c3593d7 Compare September 4, 2026 04:24
@koxudaxi
koxudaxi force-pushed the fix/input-format-semantics branch from c3593d7 to f31e554 Compare September 4, 2026 04:44
@koxudaxi
koxudaxi merged commit 4cd5607 into main Sep 4, 2026
66 of 67 checks passed
@koxudaxi
koxudaxi deleted the fix/input-format-semantics branch September 4, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant